[Resolve #1503] Dependency conflict with packaging #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the flexible constraints on packaging, allowing >=16.8 for compatibility with many old tools in the Sceptre ecosystem.
ericabrauer
approved these changes
Aug 27, 2024
It doesn't revert PR #1495, it restores the original version that I did of PR #1495. I believe the right thing to do here is merge this PR as soon as possible, otherwise latest Sceptre is broken for everyone in the world who tries to install any of our plugins along side of Sceptre. The other option would be to find and re-release every single plugin that has the 16.8 packaging dependency. That would take some time. |
zaro0508
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the flexible constraints on packaging, allowing >=16.8 for compatibility with many old tools in the Sceptre ecosystem.
For example:
https://github.com/Sceptre/sceptre-aws-stackoutput-resolver/blob/master/requirements.txt#L6
PR Checklist
[Resolve #issue-number].poetry run tox) are passing.poetry run pre-commit run --all-files).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit